OCTRL-1095: Create observability stack for kubernetes operators#822
Draft
justonedev1 wants to merge 3 commits into
Draft
OCTRL-1095: Create observability stack for kubernetes operators#822justonedev1 wants to merge 3 commits into
justonedev1 wants to merge 3 commits into
Conversation
justonedev1
force-pushed
the
OCTRL-1095-all
branch
from
0fef9e7 to
b8c1927
Compare
knopers8
reviewed
Jul 1, 2026
Comment on lines
+94
to
+95
| ConditionStateInitialized = "StateInitialized" | ||
| ConditionStateTransitioned = "StateTransitioned" |
Collaborator
There was a problem hiding this comment.
What do they mean exaclty? State transition started and finished?
| func (r *TaskReconciler) recordCondition(ctx context.Context, t *aliecsv1alpha1.Task, condType string, condStatus metav1.ConditionStatus, reason, message string) error { | ||
| patch := client.MergeFrom(t.DeepCopy()) | ||
| eventType := v1.EventTypeNormal | ||
| if condStatus == metav1.ConditionFalse { |
Collaborator
There was a problem hiding this comment.
out of curiosity, is a false condition by convention something bad, given that we automatically make it a warning?
|
|
||
| Pod deletion (which sets the pod to Terminating) is captured at `Metadata` level via `verb: delete`. | ||
|
|
||
| What is **not** captured: pod status transitions (Running → Terminating → Succeeded/Failed) — these are `patch` operations on the Pod object and are excluded to avoid noise. |
Collaborator
There was a problem hiding this comment.
hmm, why noise? i imagine those could be helpful as well.
Collaborator
Author
There was a problem hiding this comment.
noise in a sense that they should be already inside the Pod object, so it isn't necessary to copy them (at least that was the reasoning)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.